Refine desktop location fetch #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, don't fetch location on loading the desktop view.
miles-grant-ibigroup
approved these changes
Aug 30, 2023
| // On desktop, after user clicks "Use location" from the location fields, | ||
| // show an alert and explain if location is blocked. | ||
| if (!isMobile() && error.code === 1) { | ||
| window.alert( |
There was a problem hiding this comment.
A bit clunky, but I think good enough for now! Could we possibly add a TODO here to move this code into location-field and handle this more elgantly
There was a problem hiding this comment.
I added the TODO in 933d34a.
binh-dam-ibigroup
requested review from
philip-cline
and removed request for
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Undoes #984 and instead, displays an alert on desktop when attempting to use the current location for the first time after loading the page, and location access is blocked.
i18n messages are provided when the user denied location access.
PR Checklist